Don't send so many synonyms #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongreyber
approved these changes
Sep 28, 2021
| """Map single CURIE.""" | ||
| try: | ||
| categories, identifiers = data[curie] | ||
| except KeyError: | ||
| return [curie] | ||
| prefixes = { | ||
| prefixes = list(dict.fromkeys( |
There was a problem hiding this comment.
Is this just to deduplicate? Maybe switch to set() if that's the case.
There was a problem hiding this comment.
Yes, we need to deduplicate but also retain the order, which is why I've done this rather than using set().
There was a problem hiding this comment.
Gotcha. Can we document this in a comment?
| for _curie in identifiers | ||
| if _curie.startswith(prefix) | ||
| ] | ||
| if curies: |
There was a problem hiding this comment.
So this returns curies for the first prefix where curies exist, instead of all curies for all prefixes? If I'm understanding it right, can we document this behavior explicitly in a docstring or comment?
patrickkwang
force-pushed
the
trim-syns
branch
from
8fac2b0 to
a797fd2
Compare
patrickkwang
force-pushed
the
trim-syns
branch
from
a797fd2 to
59980fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.